chore: Adds release workflow and updates module name #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maastha
commented
Feb 23, 2025
| @@ -1,4 +1,4 @@ | |||
| module go.mongodb.org/atlas-appservices | |||
| module github.com/mongodb-labs/go-client-mongodb-atlas-app-services | |||
There was a problem hiding this comment.
updating module name to match the repo for easy installation otherwise a vanity URL setup would be required
lantoli
reviewed
Feb 24, 2025
| - "${signature}" | ||
| - "--detach-sign" | ||
| - "${artifact}" | ||
|
|
There was a problem hiding this comment.
you can add prerelease param is you want to support pre-releases, e.g.: https://github.com/mongodb-labs/atlas-cli-plugin-terraform/blob/153a3877c13a52101879f7f32150107a5210d4fa/.goreleaser.yaml#L57
There was a problem hiding this comment.
I don't think that's required at this point. Since this will eventually be deprecated and I don't see much use-cases for pre-releases as this client is quite light anyway
lantoli
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Tested release process in forked repo: https://github.com/maastha/go-client-mongodb-atlas-app-services/releases/tag/v0.0.2-pre
Jira ticket: CLOUDP-273338
Checklist
make fmtand formatted my codeFurther comments